Skip to content

fix: Using cached-property instead of async #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2022
Merged

fix: Using cached-property instead of async #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12dd8aa
build: Using cached-property package
ptiurin Nov 24, 2022
477f63f
remove new library
ptiurin Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ install_requires =
aiorwlock==1.1.0
appdirs>=1.4.4
appdirs-stubs>=0.1.0
async-property==0.2.1
cryptography>=3.4.0
httpx[http2]==0.23.0
pydantic[dotenv]>=1.8.2,<1.10
Expand Down
3 changes: 1 addition & 2 deletions src/firebolt/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Any, Optional

from anyio._core._eventloop import get_asynclib
from async_property import async_cached_property # type: ignore
from httpx import URL
from httpx import AsyncClient as HttpxAsyncClient
from httpx import Client as HttpxClient
Expand Down Expand Up @@ -123,7 +122,7 @@ class AsyncClient(FireboltClientMixin, HttpxAsyncClient):
FireboltAuth instance.
"""

@async_cached_property
@cached_property
async def account_id(self) -> str:
"""User account id.

Expand Down