feat: Fir 15407 new output format #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
approved these changes
Jan 30, 2023
Contributor
ptiurin
left a comment
ptiurin
left a comment
There was a problem hiding this comment.
Quick note, otherwise looks good.
| TimestampNtz = "TimestampNtz" | ||
| TimestampTz = "TimestampTz" | ||
| Timestamp = "timestamp" | ||
| TimestampExt = "timestamp_ext" |
Contributor
There was a problem hiding this comment.
I think Mosha said timestamp_ext is no longer supported. Might as well get rid of it.
Collaborator
Author
There was a problem hiding this comment.
A query like CAST('2019-07-31 01:01:01.1234' AS TIMESTAMP_EXT(4)) still return timestamp_ext for me, I guess we`ll need to keep it for now
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed output format from
JSONCompacttoJSON_Compact. Added support for new Firebolt-style types.