feat: Fir 16953 bytea support #235
Conversation
stepansergeevitch
changed the title
| BYTEA_PREFIX = "\\x" | ||
|
|
||
|
|
||
| def _parse_bytea(str_value: str) -> bytes: | ||
| return bytes.fromhex(str_value[len(BYTEA_PREFIX) :]) |
There was a problem hiding this comment.
Should we check if the string starts with the correct prefix?
There was a problem hiding this comment.
My idea was that it might be a pretty heavy operation on a large scale (since string slice is basically copy). Yet, I think we should be fine in a general case, we have less performant pieces anyway
| data = "bytea_123" | ||
|
|
||
| await c.execute( | ||
| "INSERT INTO test_bytea_roundtrip VALUES (1, ?)", (Binary(data),) |
There was a problem hiding this comment.
I'd add a couple of special characters here as well, just to make sure we handle them correctly. e.g. '\n', '\', ヽ༼ຈل͜ຈ༽ﾉ
tests/integration/dbapi/conftest.py
Outdated
| 'decimal(38,30)) as "decimal", ' | ||
| "cast(null as int) as nullable" | ||
| "cast(null as int) as nullable, " | ||
| "'abc123'::bytea as bytea" |
There was a problem hiding this comment.
Just a heads-up, unquoted identifiers are not supposed to work and SQL team has just released a fix. We should change this to as "bytea" and any other new types that worked this way.
stepansergeevitch
force-pushed
the
FIR-16953-bytea-support
branch
from
1078992 to
258112a
Compare
stepansergeevitch
force-pushed
the
FIR-16953-bytea-support
branch
from
c026bf7 to
5f2660e
Compare
|
SonarCloud Quality Gate failed. |
Added support for bytea type (both parsing and formatting)