Skip to content

Conversation

@ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Mar 6, 2023

Splitting CI to run on both main and backwards-compatibility branch 0.x.

Confirmed most workflows are working:

  • Unit tests
  • PR verify
  • Security-scan
  • integration tests

Since other wfs are copies I'm not able to verify they work until they're merged in main, but they use the similar idea to the ones that have been tested.

In checkout action, ref is the branch we want to checkout. If ref is undefined or empty it defaults to the branch the workflow is being called from soinput parameter to most of our workflows is optional. It's mainly needed for nightlies, which are always run from the main branch.

@ptiurin ptiurin marked this pull request as ready for review March 7, 2023 13:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aymeric-dispa
Copy link

LGTM 👍

Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Let's have same changes to other drivers so we can gradually unblock them

@ptiurin ptiurin merged commit 494cd5e into main Mar 9, 2023
@ptiurin ptiurin deleted the ci-version-split branch March 9, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants