test: Fix insert rowcount #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
| Column(d["name"], parse_type(d["type"]), None, None, None, None, None) | ||
| for d in query_data["meta"] | ||
| ] | ||
| if not descriptions: |
Collaborator
There was a problem hiding this comment.
Why can't we just have it empty?
Collaborator
There was a problem hiding this comment.
Ok, pep 249 says it should be None
Contributor
Author
There was a problem hiding this comment.
I feel like it's a bit counter-intuitive to receive empty array in description. For example,
A user does an INSERT query, checks cursor.rowcount is correct then checks for some reason cursor.description and it's []. The name itself implies singular as well.
I don't feel too strongly about it, but this is also how we had it up until now.
stepansergeevitch
approved these changes
Mar 17, 2023
| Column(d["name"], parse_type(d["type"]), None, None, None, None, None) | ||
| for d in query_data["meta"] | ||
| ] | ||
| if not descriptions: |
Collaborator
There was a problem hiding this comment.
Ok, pep 249 says it should be None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes to aragog API behaviour has changed. Modifying our tests to account for it.