Skip to content

test: Remove insert rowcount test #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023
Merged

test: Remove insert rowcount test #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80682c
test: Remove insert rowcount test
ptiurin Mar 31, 2023
d12ea03
Merge branch 'main' into fix-rowcount-test
ptiurin Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions tests/integration/dbapi/async/test_queries_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,15 +382,11 @@ async def test_multi_statement_query(connection: Connection) -> None:
" primary index i"
)

assert (
await c.execute(
"INSERT INTO test_tb_async_multi_statement values (1, 'a'), (2, 'b');"
"SELECT * FROM test_tb_async_multi_statement;"
"SELECT * FROM test_tb_async_multi_statement WHERE i <= 1"
)
== 1 # Insert always returns 1 row with num of rows modified
), "Invalid row count returned for insert"
assert c.rowcount == 1, "Invalid row count"
await c.execute(
"INSERT INTO test_tb_async_multi_statement values (1, 'a'), (2, 'b');"
"SELECT * FROM test_tb_async_multi_statement;"
"SELECT * FROM test_tb_async_multi_statement WHERE i <= 1"
)
assert c.description is None, "Invalid description"

assert await c.nextset()
Expand Down
14 changes: 5 additions & 9 deletions tests/integration/dbapi/sync/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,15 +327,11 @@ def test_multi_statement_query(connection: Connection) -> None:
"CREATE FACT TABLE test_tb_multi_statement(i int, s string) primary index i"
)

assert (
c.execute(
"INSERT INTO test_tb_multi_statement values (1, 'a'), (2, 'b');"
"SELECT * FROM test_tb_multi_statement;"
"SELECT * FROM test_tb_multi_statement WHERE i <= 1"
)
== 1 # Insert always returns 1 row with num of rows modified
), "Invalid row count returned for insert"
assert c.rowcount == 1, "Invalid row count"
c.execute(
"INSERT INTO test_tb_multi_statement values (1, 'a'), (2, 'b');"
"SELECT * FROM test_tb_multi_statement;"
"SELECT * FROM test_tb_multi_statement WHERE i <= 1"
)
assert c.description is None, "Invalid description"

assert c.nextset()
Expand Down