fix: Fir 14511 settings from env deprecation message #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
approved these changes
Apr 26, 2023
tests/unit/common/test_settings.py
Outdated
| assert len(err.errors()) > 0 | ||
|
|
||
| @patch("firebolt.common.settings.logger") | ||
| def test_deprecation_warning_with_env(logger_mock: Mock): |
Contributor
There was a problem hiding this comment.
nit: test_no_deprecation_warning_with_env
stepansergeevitch
force-pushed
the
FIR-14511-settings-from-env-deprecation-message
branch
from
3ae6735 to
3989f03
Compare
|
Kudos, SonarCloud Quality Gate passed! |
stepansergeevitch
deleted the
FIR-14511-settings-from-env-deprecation-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deprecation warning when username and password were provided as environment variables