Skip to content

test: Add failing settings test #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

test: Add failing settings test #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0193575
test: Add failing settings test
ptiurin May 24, 2023
0629a35
fix unit test
stepansergeevitch May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/firebolt/common/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

def from_env(var_name: str, default: Any = None) -> Callable:
def inner() -> Any:
os.environ.get(var_name, default)
return os.environ.get(var_name, default)

return inner

Expand Down
9 changes: 7 additions & 2 deletions tests/unit/common/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,16 @@ def test_settings_auth_credentials(kwargs) -> None:
def test_no_deprecation_warning_with_env(logger_mock: Mock):
with patch.dict(
os.environ,
{"FIREBOLT_USER": "user", "FIREBOLT_PASSWORD": "password"},
{
"FIREBOLT_USER": "user",
"FIREBOLT_PASSWORD": "password",
"FIREBOLT_SERVER": "dummy.firebolt.io",
},
clear=True,
):
s = Settings(server="server", default_region="region")
s = Settings(default_region="region")
logger_mock.warning.assert_not_called()
assert s.server == "dummy.firebolt.io"
assert s.auth is not None, "Settings.auth wasn't populated from env variables"
assert s.auth.username == "user", "Invalid username in Settings.auth"
assert s.auth.password == "password", "Invalid password in Settings.auth"