Skip to content

test: No rowcount check on DDL #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2023
Merged

test: No rowcount check on DDL #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0df7de0
test: No rowcount check on DDL
ptiurin May 26, 2023
3270c58
Update test_queries.py
ptiurin May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/integration/dbapi/async/test_queries_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ async def test_drop_create(connection: Connection) -> None:
async def test_query(c: Cursor, query: str) -> None:
await c.execute(query)
assert c.description == None
assert c.rowcount == -1
# This is inconsistent, commenting for now
# assert c.rowcount == -1

"""Create table query is handled properly"""
with connection.cursor() as c:
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/dbapi/sync/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def test_drop_create(connection: Connection) -> None:
def test_query(c: Cursor, query: str) -> None:
c.execute(query)
assert c.description == None
assert c.rowcount == -1
# Inconsistent behaviour in Firebolt
# assert c.rowcount == -1

"""Create table query is handled properly"""
with connection.cursor() as c:
Expand Down