Skip to content

Conversation

@stepansergeevitch
Copy link
Collaborator

Updated SDK to support new identity

  • Updated authentication to work with new SAs
  • Updated connection flow to use a new SQL API
  • Updated integration and unit tests

@stepansergeevitch stepansergeevitch requested a review from ptiurin June 7, 2023 10:06
@stepansergeevitch stepansergeevitch changed the title Fir 21171 new identity support feat: Fir 21171 new identity support Jun 7, 2023
Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but generally looks good! 👍

@ptiurin
Copy link
Contributor

ptiurin commented Jun 13, 2023

Also, dependency hell in unit tests :'(

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.8% 88.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepansergeevitch stepansergeevitch merged commit 6a809bc into main Jun 14, 2023
@stepansergeevitch stepansergeevitch deleted the FIR-21171-new-identity-support branch June 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants