feat: Fir 24158 new identity resource manager #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
reviewed
Jun 23, 2023
Contributor
ptiurin
left a comment
ptiurin
left a comment
There was a problem hiding this comment.
Also, unit tests are kaput :'(
Comment on lines
+101
to
+107
| def refresh(self) -> None: | ||
| """Update attributes of the instance from Firebolt.""" | ||
| field_name_overrides = self._get_field_overrides() | ||
| for name, value in self._service._get_dict(self.name).items(): | ||
| setattr(self, field_name_overrides.get(name, name), value) | ||
|
|
||
| self.__post_init__() |
Contributor
There was a problem hiding this comment.
I'm not entirely clear why we're refreshing attributes here?
Collaborator
Author
There was a problem hiding this comment.
We just fetch the engine state from db and update each class field with a new value.
Then we do post init for value post processing
stepansergeevitch
force-pushed
the
FIR-24158-new-identity-resource-manager
branch
from
204ea67 to
ac9c7c7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ResourceManager to use a new SQL api to handle resources