ci: run only failed tests when re-running #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RotemFB
changed the title
ptiurin
reviewed
Jul 19, 2023
| - name: Save failed tests | ||
| id: cache-tests-save | ||
| uses: actions/cache/save@v3 | ||
| if: always() |
Contributor
There was a problem hiding this comment.
I would even put here if: failure() so we don't bother trying to save nothing when nothing fails.
| - name: Save failed tests | ||
| id: cache-tests-save | ||
| uses: actions/cache/save@v3 | ||
| if: always() |
Contributor
There was a problem hiding this comment.
I don't think it's worth adding to unit tests at all - they run in seconds and rerunning them is no big deal. Let's keep them simple!
ptiurin
approved these changes
Jul 19, 2023
Contributor
ptiurin
left a comment
ptiurin
left a comment
There was a problem hiding this comment.
lgtm, just trim the whitespace in unit-test.yml to keep the changelog clean
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using cache in the ci in order to re-run only the failed tests in order to save some time