test: Fix integration tests for new identity #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
alexradzin
reviewed
Jul 24, 2023
alexradzin
left a comment
alexradzin
left a comment
There was a problem hiding this comment.
I want to approve this PR because I do not understand it anyway. Unfortunately I cannot choose "approve", probably it is because I have added comments.
I have added a couple of questions and will appreciate if you can explain me. Also please take a look on 3 "code smells" found by Sonar.
alexradzin
approved these changes
Jul 24, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Collaborator
Author
|
Integration tests are passing: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/5645658069/job/15316646593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed integration tests issues, that appeared in new identity. Removed some existing system engine tests, since they've overlapped with resource manager tests.
Successful integration tests run: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/5642758144