Skip to content

Conversation

@stepansergeevitch
Copy link
Collaborator

Updated readme docs and added examples of using service account authentication to connect.

@stepansergeevitch stepansergeevitch self-assigned this Aug 9, 2023
@stepansergeevitch stepansergeevitch changed the title Fir 25275 service account examples docs: Fir 25275 service account examples Aug 9, 2023
Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that LGTM

password=SecretStr("*****"),
auth=UsernamePassword("email@domain.com", "*****")
account_name="account", # Necessary if you have multiple accounts.
server="api.app.firebolt.io",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use DEFAULT_API_URL here, for consistency sake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stepansergeevitch stepansergeevitch merged commit f0aa235 into 0.x Aug 9, 2023
@stepansergeevitch stepansergeevitch deleted the FIR-25275-service-account-examples branch August 9, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants