-
Notifications
You must be signed in to change notification settings - Fork 11
docs: Fir 25275 service account examples #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ptiurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that LGTM
README_MANAGEMENT.md
Outdated
| password=SecretStr("*****"), | ||
| auth=UsernamePassword("email@domain.com", "*****") | ||
| account_name="account", # Necessary if you have multiple accounts. | ||
| server="api.app.firebolt.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use DEFAULT_API_URL here, for consistency sake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
|
Kudos, SonarCloud Quality Gate passed!
|









Updated readme docs and added examples of using service account authentication to connect.