Skip to content

Conversation

@RotemFB
Copy link
Contributor

@RotemFB RotemFB commented Aug 10, 2023

when deleting a database the check if the attached engines are starting or stopping was wrong

@RotemFB RotemFB self-assigned this Aug 10, 2023
@ptiurin
Copy link
Contributor

ptiurin commented Aug 10, 2023

Would you be able to add some tests for this?

@RotemFB RotemFB requested a review from ptiurin September 6, 2023 10:02
@RotemFB RotemFB requested a review from ptiurin September 12, 2023 10:35
Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@RotemFB RotemFB merged commit 894eda3 into main Sep 12, 2023
@RotemFB RotemFB deleted the fix-delete-db-with-busy-engine branch September 12, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants