Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/firebolt/service/database.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ def get(self, name: str) -> Database:
"""Get a Database from Firebolt by its name."""
return Database._from_dict(self._get_dict(name), self)

def get_by_name(self, name: str) -> Database:
return self.get(name)

def get_many(
self,
name_contains: Optional[str] = None,
Expand Down
3 changes: 3 additions & 0 deletions src/firebolt/service/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ def get(self, name: str) -> Engine:
"""Get an engine from Firebolt by its name."""
return Engine._from_dict(self._get_dict(name), self)

def get_by_name(self, name: str) -> Engine:
return self.get(name)

def get_many(
self,
name_contains: Optional[str] = None,
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/service/test_database.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,22 @@ def test_database_create(
assert database == mock_database


def test_database_get_by_name(
httpx_mock: HTTPXMock,
resource_manager: ResourceManager,
database_get_callback: Callable,
system_engine_no_db_query_url: str,
mock_database: Database,
):
httpx_mock.add_callback(
database_get_callback, url=system_engine_no_db_query_url, method="POST"
)

database = resource_manager.databases.get_by_name(mock_database.name)

assert database == mock_database


def test_database_get(
httpx_mock: HTTPXMock,
resource_manager: ResourceManager,
Expand Down
17 changes: 17 additions & 0 deletions tests/unit/service/test_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,20 @@ def test_engine_update_auto_stop_zero(
mock_engine.update(auto_stop=0)

assert mock_engine.auto_stop == updated_auto_stop


def test_engine_get_by_name(
httpx_mock: HTTPXMock,
resource_manager: ResourceManager,
instance_type_callback: Callable,
instance_type_url: str,
get_engine_callback: Callable,
system_engine_no_db_query_url: str,
mock_engine: Engine,
):
httpx_mock.add_callback(instance_type_callback, url=instance_type_url)
httpx_mock.add_callback(get_engine_callback, url=system_engine_no_db_query_url)

engine = resource_manager.engines.get_by_name(mock_engine.name)

assert engine == mock_engine