test: Integration testing account v2 #383
Conversation
stepansergeevitch
changed the title
| "", | ||
| "", |
There was a problem hiding this comment.
Why do we have empty strings here?
There was a problem hiding this comment.
Since fields names are accessed by index, we simply store empty strings to preserve order, yet we verify that this field is not accessed by an invalid account version. Converting this to a map would involve a lot of refactoring, yet we can do that if you have a strong opinion here. We should generally be able to simplify this list when we'll deprecate v1 engines fully
There was a problem hiding this comment.
Fair enough, not feeling too strongly about it. Maybe let's just add a comment that this is left for compatibility.
|
Integration tests: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/9269779587 |
| "", | ||
| "", |
There was a problem hiding this comment.
Fair enough, not feeling too strongly about it. Maybe let's just add a comment that this is left for compatibility.
|
2 participants
Created a separate integration testing workflow to run a full integration test suite on account v2. Made some fixes and improvements (mainly to resource management) to make sure tests are passing