fix: Fir 35673 python sdk engine update fix renaming #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
reviewed
Aug 13, 2024
| param, value | ||
| parameters: List[Union[str, int]] = [] | ||
| if name is not None: | ||
| if not self._engine_name_re.match(name): |
There was a problem hiding this comment.
I'm thinking from a readability perspective, we can potentially do name.replace('_', '').isalnum() here and avoid regex altogether.
Don't feel too strongly about it, so up to you.
There was a problem hiding this comment.
I would rather stick to the regexp as it fells more straightforward, while removing characters might be slightly confusing during reading
| ) | ||
| DROP_SQL: ClassVar[str] = 'DROP ENGINE "{}"' | ||
|
|
||
| _engine_name_re = re.compile(r"^[a-zA-Z0-9_]+$") |
There was a problem hiding this comment.
If we keep the regex approach let's pop a comment above it - "engine names can only be alphanumeric with underscores". Saves a second having to read the regex itself.
ptiurin
approved these changes
Aug 13, 2024
|
stepansergeevitch
deleted the
FIR-35673-python-sdk-engine-update-fix-renaming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed engine renaming for fb2.0