fix(FIR-49285): remove incompatible method call for python 3.12 #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
force-pushed
the
fix-3.12-compatibility
branch
from
846ddc3 to
0e2251a
Compare
gm42
previously approved these changes
Sep 17, 2025
bogdantruta-firebolt
previously approved these changes
Sep 18, 2025
ptiurin
dismissed stale reviews from bogdantruta-firebolt and gm42
The base branch was changed.
ptiurin
force-pushed
the
fix-3.12-compatibility
branch
from
94749f1 to
57b6cf4
Compare
bogdantruta-firebolt
approved these changes
Sep 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distutil has been removed from Python 3.12 so we can no longer use it. Moving the only function we were using to the codebase itself.
Adding tests in Nightlies to verify we're running on Python 3.12 as well as 3.13 without issues.
3.8 has been discontinued - https://devguide.python.org/versions/