Skip to content

FIR-9109: Improving tests #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 22, 2021
Merged

FIR-9109: Improving tests #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0165362
Splitting and adding unit tests
petrotiurin Nov 17, 2021
f0a48eb
Testing dialect types
petrotiurin Nov 17, 2021
8065d39
Adding integration tests
petrotiurin Nov 18, 2021
da09144
Not masking errors in the integration
petrotiurin Nov 18, 2021
f553a42
Fix skipped tests
petrotiurin Nov 18, 2021
54ae2ad
Adding condition to failing tests
petrotiurin Nov 18, 2021
3bc3407
Adding explanation for odd unit test
petrotiurin Nov 18, 2021
9813281
Formatting linting changes
petrotiurin Nov 18, 2021
e37fb46
Refactor and cleanup
petrotiurin Nov 19, 2021
25093d1
Fix typo
petrotiurin Nov 19, 2021
cb2fc47
Refactor unit tests
petrotiurin Nov 19, 2021
82f35ba
Remove ci folder
petrotiurin Nov 19, 2021
f1d4b53
Formatting fixes
petrotiurin Nov 19, 2021
f9f5403
Adding typehints to tests
petrotiurin Nov 22, 2021
cd114d6
Removing redundant operation
petrotiurin Nov 22, 2021
277c978
Returning db api object on dbapi() call
petrotiurin Nov 22, 2021
019023b
Removing redundant import in __init__
petrotiurin Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
350 changes: 0 additions & 350 deletions ci/firebolt_ingest_data.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/firebolt_db/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from firebolt.db import connect
from firebolt.common.exception import (
DatabaseError,
DataError,
Expand Down
5 changes: 2 additions & 3 deletions src/firebolt_db/firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
CHAR, DATE, DATETIME, INTEGER, BIGINT,
TIMESTAMP, VARCHAR, BOOLEAN, FLOAT)

import firebolt_db
import os

import firebolt.db

class ARRAY(sqltypes.TypeEngine):
__visit_name__ = 'ARRAY'
Expand Down Expand Up @@ -82,7 +81,7 @@ def __init__(self, context=None, *args, **kwargs):

@classmethod
def dbapi(cls):
return firebolt_db
return firebolt.db

# Build firebolt-sdk compatible connection arguments.
# URL format : firebolt://username:password@host:port/db_name
Expand Down
Loading