Skip to content

feat: Removing explicit dialect register #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

feat: Removing explicit dialect register #36

merged 1 commit into from
Dec 30, 2021

Conversation

@ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Dec 30, 2021

This setting automatically registers the dialect with the sqlalchemy so the users don't need to manually call registry.register
https://docs.sqlalchemy.org/en/14/core/connections.html#registering-new-dialects

stepansergeevitch
stepansergeevitch approved these changes Dec 30, 2021
View reviewed changes
Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ptiurin ptiurin merged commit 588ab9e into master Dec 30, 2021
@ptiurin ptiurin deleted the feat_no_register branch December 30, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptiurin @stepansergeevitch