Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/firebolt_db/firebolt_dialect.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ def create_connect_args(self, url: URL) -> Tuple[List, Dict]:
def get_schema_names(
self, connection: AlchemyConnection, **kwargs: Any
) -> List[str]:
query = "select schema_name from information_schema.databases"
result = connection.execute(text(query))
return [row.schema_name for row in result]
# There's no support for schemas in Firebolt at the moment
# Public is used as a placeholder in many system tables.
return ["public"]

def has_table(
self,
Expand Down
6 changes: 5 additions & 1 deletion tests/integration/test_sqlalchemy_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_data_write(self, connection: Connection, fact_table_name: str):

def test_get_schema_names(self, engine: Engine, database_name: str):
results = engine.dialect.get_schema_names(engine)
assert database_name in results
assert "public" in results

def test_has_table(self, engine: Engine, fact_table_name: str):
results = engine.dialect.has_table(engine, fact_table_name)
Expand All @@ -58,6 +58,10 @@ def test_has_table(self, engine: Engine, fact_table_name: str):
def test_get_table_names(self, engine: Engine):
results = engine.dialect.get_table_names(engine)
assert len(results) > 0
results = engine.dialect.get_table_names(engine, "public")
assert len(results) > 0
results = engine.dialect.get_table_names(engine, "non_existing_schema")
assert len(results) == 0

def test_get_columns(self, engine: Engine, fact_table_name: str):
results = engine.dialect.get_columns(engine, fact_table_name)
Expand Down
13 changes: 1 addition & 12 deletions tests/unit/test_firebolt_dialect.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,19 +116,8 @@ def test_do_execute(
def test_schema_names(
self, dialect: FireboltDialect, connection: mock.Mock(spec=MockDBApi)
):
def row_with_schema(name):
return mock.Mock(schema_name=name)

connection.execute.return_value = [
row_with_schema("schema1"),
row_with_schema("schema2"),
]
result = dialect.get_schema_names(connection)
assert result == ["schema1", "schema2"]
connection.execute.assert_called_once()
assert str(connection.execute.call_args[0][0].compile()) == str(
text("select schema_name from information_schema.databases").compile()
)
assert result == ["public"]

def test_table_names(
self, dialect: FireboltDialect, connection: mock.Mock(spec=MockDBApi)
Expand Down