Skip to content

chore: unpin SDK version #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2022
Merged

chore: unpin SDK version #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c95494f
chore: unpin SDK version
ptiurin Sep 7, 2022
89e083e
Remove old set parameter functionality from async
ptiurin Sep 7, 2022
7cca6d2
Remove set parameters from tests
ptiurin Sep 7, 2022
761337b
mypy fix
ptiurin Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ project_urls =
[options]
packages = find:
install_requires =
firebolt-sdk==0.9.2
firebolt-sdk>=0.9.2
sqlalchemy>=1.0.0
python_requires = >=3.7
package_dir =
Expand Down
8 changes: 2 additions & 6 deletions src/firebolt_db/firebolt_async_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,16 @@ def execute(
self,
operation: str,
parameters: Optional[Tuple] = None,
set_parameters: Optional[Dict] = None,
) -> None:
self.await_(self._execute(operation, parameters, set_parameters=set_parameters))
self.await_(self._execute(operation, parameters))

async def _execute(
self,
operation: str,
parameters: Optional[Tuple] = None,
set_parameters: Optional[Dict] = None,
) -> None:
async with self._adapt_connection._execute_mutex:
await self._cursor.execute(
operation, parameters, set_parameters=set_parameters
)
await self._cursor.execute(operation, parameters)
if self._cursor.description:
self._rows = await self._cursor.fetchall()
else:
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_firebolt_async_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_cursor() -> AsyncCursorWrapper:
assert wrapper.description == "dummy"
assert wrapper.rowcount == -1
async_cursor.execute.assert_awaited_once_with(
"INSERT INTO test(a, b) VALUES (?, ?)", [(1, "a")], set_parameters=None
"INSERT INTO test(a, b) VALUES (?, ?)", [(1, "a")]
)
async_cursor.fetchall.assert_awaited_once()

Expand All @@ -105,7 +105,7 @@ def test_cursor() -> AsyncCursorWrapper:
assert wrapper.description is None
assert wrapper.rowcount == 100
async_cursor.execute.assert_awaited_once_with(
"INSERT INTO test(a, b) VALUES (?, ?)", [(1, "a")], set_parameters=None
"INSERT INTO test(a, b) VALUES (?, ?)", [(1, "a")]
)
async_cursor.fetchall.assert_not_awaited()

Expand Down