Skip to content

test: Skip delete tests #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged

test: Skip delete tests #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/integration/test_sqlalchemy_async_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ async def test_data_write(self, async_connection: Connection, fact_table_name: s
f"UPDATE {fact_table_name} SET dummy='some_other_text' WHERE idx=1"
)
)
# Delete not supported
with pytest.raises(OperationalError):
await async_connection.execute(
text(f"DELETE FROM {fact_table_name} WHERE idx=1")
)
# Delete works but is not officially supported yet
# with pytest.raises(OperationalError):
# await async_connection.execute(
# text(f"DELETE FROM {fact_table_name} WHERE idx=1")
# )

@pytest.mark.asyncio
async def test_set_params(self, async_connection: Engine):
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/test_sqlalchemy_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ def test_data_write(self, connection: Connection, fact_table_name: str):
connection.execute(
f"UPDATE {fact_table_name} SET dummy='some_other_text' WHERE idx=1"
)
# Delete not supported
with pytest.raises(OperationalError):
connection.execute(f"DELETE FROM {fact_table_name} WHERE idx=1")
# Delete works but is not officially supported yet
# with pytest.raises(OperationalError):
# connection.execute(f"DELETE FROM {fact_table_name} WHERE idx=1")

def test_firebolt_types(self, connection: Connection):
result = connection.execute("SELECT '1896-01-01' :: DATE_EXT")
Expand Down