Skip to content

ci: Fix pre-commit #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2023
Merged

ci: Fix pre-commit #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11a4f14
ci: Fix pre-commit
ptiurin Feb 23, 2023
26fecf6
Update code-check.yml
ptiurin Feb 23, 2023
6d95f4a
Update .pre-commit-config.yaml
ptiurin Feb 23, 2023
3412405
fstring fix
ptiurin Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
- name: Check out code
uses: actions/checkout@v2

- name: Set up Python 3.7
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.7
python-version: 3.8

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ repos:
- --remove-unused-variables

- repo: https://github.com/PyCQA/isort
rev: 5.9.3
rev: "5.12.0"
hooks:
- id: isort

Expand All @@ -39,7 +39,7 @@ repos:
- id: black_nbconvert

- repo: https://github.com/PyCQA/flake8
rev: 3.7.9
rev: "4.0.1"
hooks:
- id: flake8
additional_dependencies:
Expand Down
10 changes: 5 additions & 5 deletions tests/integration/test_sqlalchemy_async_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ async def test_data_write(self, async_connection: Connection, fact_table_name: s

@pytest.mark.asyncio
async def test_set_params(self, async_connection: Engine):
await async_connection.execute(text(f"SET advanced_mode=1"))
await async_connection.execute(text(f"SET use_standard_sql=0"))
await async_connection.execute(text("SET advanced_mode=1"))
await async_connection.execute(text("SET use_standard_sql=0"))
result = await async_connection.execute(
text(f"SELECT sleepEachRow(1) from numbers(1)")
text("SELECT sleepEachRow(1) from numbers(1)")
)
assert len(result.fetchall()) == 1
await async_connection.execute(text(f"SET use_standard_sql=1"))
await async_connection.execute(text(f"SET advanced_mode=0"))
await async_connection.execute(text("SET use_standard_sql=1"))
await async_connection.execute(text("SET advanced_mode=0"))

@pytest.mark.asyncio
async def test_get_table_names(self, async_connection: Connection):
Expand Down