Skip to content

fix: Changing classes to their closest Firebolt equivalent #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2023
Merged

fix: Changing classes to their closest Firebolt equivalent #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae88067
fix: Numeric type
ptiurin Apr 25, 2023
eb075f9
fix blob
ptiurin Apr 25, 2023
94b8780
Rename to Firebolt names
ptiurin Apr 25, 2023
7822870
test fixes
ptiurin Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/firebolt_db/firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
ARRAY,
BIGINT,
BOOLEAN,
CHAR,
DATE,
DATETIME,
FLOAT,
INTEGER,
NUMERIC,
REAL,
TEXT,
TIMESTAMP,
VARCHAR,
)


Expand All @@ -31,14 +31,15 @@ class BYTEA(sqltypes.LargeBinary):

# Firebolt data types compatibility with sqlalchemy.sql.types
type_map = {
"char": CHAR,
"text": VARCHAR,
"varchar": VARCHAR,
"string": VARCHAR,
"float": FLOAT,
"double": FLOAT,
"double precision": FLOAT,
"real": FLOAT,
"text": TEXT,
"varchar": TEXT,
"string": TEXT,
"float": REAL,
"double": REAL,
"double precision": REAL,
"numeric": NUMERIC,
"decimal": NUMERIC,
"real": REAL,
"boolean": BOOLEAN,
"int": INTEGER,
"integer": INTEGER,
Expand Down Expand Up @@ -76,7 +77,7 @@ def removesuffix(s: str, suffix: str) -> str:
return result


DEFAULT_TYPE = VARCHAR
DEFAULT_TYPE = TEXT


class UniversalSet(set):
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/test_firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,12 @@ def test_get_is_nullable():


def test_types():
assert firebolt_db.firebolt_dialect.CHAR is sqlalchemy.sql.sqltypes.CHAR
assert firebolt_db.firebolt_dialect.DATE is sqlalchemy.sql.sqltypes.DATE
assert firebolt_db.firebolt_dialect.DATETIME is sqlalchemy.sql.sqltypes.DATETIME
assert firebolt_db.firebolt_dialect.INTEGER is sqlalchemy.sql.sqltypes.INTEGER
assert firebolt_db.firebolt_dialect.BIGINT is sqlalchemy.sql.sqltypes.BIGINT
assert firebolt_db.firebolt_dialect.TIMESTAMP is sqlalchemy.sql.sqltypes.TIMESTAMP
assert firebolt_db.firebolt_dialect.VARCHAR is sqlalchemy.sql.sqltypes.VARCHAR
assert firebolt_db.firebolt_dialect.TEXT is sqlalchemy.sql.sqltypes.TEXT
assert firebolt_db.firebolt_dialect.BOOLEAN is sqlalchemy.sql.sqltypes.BOOLEAN
assert firebolt_db.firebolt_dialect.FLOAT is sqlalchemy.sql.sqltypes.FLOAT
assert firebolt_db.firebolt_dialect.REAL is sqlalchemy.sql.sqltypes.REAL
assert issubclass(firebolt_db.firebolt_dialect.ARRAY, sqlalchemy.types.TypeEngine)