feat: Identity compatibility #85
Conversation
|
Integration tests passing |
|
Kudos, SonarCloud Quality Gate passed!
|
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v2 | ||
| with: |
There was a problem hiding this comment.
What will happen if action is triggered automatically from a push to 0.x branch? Will inputs.branch have a correct value?
There was a problem hiding this comment.
When empty it defaults to the "event" that triggered the run. In this case it will checkout 0.x branch.
https://github.com/actions/checkout#usage
| connection = await_only(self.dbapi.connect(*arg, **kw)) # type: ignore[attr-defined] # noqa: F821,E501 | ||
| # Synchronously establish a connection that can execute | ||
| # asynchronous queries later | ||
| conn_func = partial(self.dbapi.connect, *arg, **kw) # type: ignore[attr-defined] # noqa: F821,E501 |
There was a problem hiding this comment.
nit: I believe we can just do self.dbapi.connect(*arg, **kw) instead of using partial
There was a problem hiding this comment.
From my testing run accepts only an async function as a first parameter, not a coroutine object that results from self.dbapi.connect(*arg, **kw). It does accept args, but kwargs have to be passed as a partial, I'm afraid.
|
Docs were merged so I'm merging this PR - firebolt-db/firebolt-db.github.io#170 |
2 participants
Compatibility with Firebolt 2.0 and firebolt-sdk 1.x