Skip to content

fix: Make account name optional #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Make account name optional #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/firebolt_db/firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ def create_connect_args(self, url: URL) -> Tuple[List, Dict]:
additional_parameters = {}
if "account_name" in parameters:
kwargs["account_name"] = parameters.pop("account_name")
else:
elif isinstance(auth, ClientCredentials):
# account_name is required for client credentials authentication
raise ArgumentError(
"account_name parameter must be provided to authenticate"
)
Expand Down
1 change: 0 additions & 1 deletion tests/unit/test_firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def test_create_dialect(self, dialect: FireboltDialect):
def test_create_connect_args_user_password(self, dialect: FireboltDialect):
u = url.make_url(
"test_engine://test-sa@user.com:test_password@test_db_name/test_engine_name"
"?account_name=dummy"
)
with mock.patch.dict(os.environ, {"FIREBOLT_BASE_URL": "test_url"}):
result_list, result_dict = dialect.create_connect_args(u)
Expand Down