Skip to content

fix: Addresses SA warnings #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: Addresses SA warnings #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/firebolt_db/firebolt_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ class FireboltDialect(default.DefaultDialect):
supports_empty_insert = False
supports_unicode_statements = True
supports_unicode_binds = True
supports_statement_cache = False
# supports_statement_cache Set to False to disable warning
# https://sqlalche.me/e/20/cprf
returns_unicode_strings = True
description_encoding = None
supports_native_boolean = True
Expand All @@ -131,7 +134,11 @@ def __init__(
self.context: Union[ExecutionContext, Dict] = context or {}

@classmethod
def dbapi(cls) -> ModuleType:
def import_dbapi(cls) -> ModuleType: # For sqlalchemy >= 2.0.0
return dbapi

@classmethod
def dbapi(cls) -> ModuleType: # Kept for backwards compatibility
return dbapi

def create_connect_args(self, url: URL) -> Tuple[List, Dict]:
Expand Down