Skip to content

fix: Specify async queue pool for async dialect #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: Specify async queue pool for async dialect #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/firebolt_db/firebolt_async_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@

import firebolt.async_db as async_dbapi
from firebolt.async_db import Connection
from sqlalchemy.engine import AdaptedConnection # type: ignore[attr-defined]

# Ignoring type since sqlalchemy-stubs doesn't cover AdaptedConnection
# and util.concurrency
from sqlalchemy.engine import AdaptedConnection # type: ignore[attr-defined]
from sqlalchemy.pool import AsyncAdaptedQueuePool # type: ignore[attr-defined]
from sqlalchemy.util.concurrency import await_only # type: ignore[import]
from trio import run

Expand Down Expand Up @@ -167,6 +168,7 @@ class AsyncFireboltDialect(FireboltDialect):
supports_statement_cache: bool = False
supports_server_side_cursors: bool = False
is_async: bool = True
poolclass = AsyncAdaptedQueuePool

@classmethod
def dbapi(cls) -> AsyncAPIWrapper:
Expand Down