Skip to content

Commit a63bf07

Browse files
committed
test(net): relax timeouts
The main reason we have timeouts is so that we can get some useful debugging information in case they do happen. This means the timesouts only need to be strict enough to avoid running into the pytest timeout instead. 10s/1s however still gets us spurious failures, since in the non-performance tests contention on host networking resources (we use a TON of networking namespaces) is pretty bad. So increase the timeouts to something that still allows us to not run into the pytest timeout, while hopefully returning spurious failures once and for all. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
1 parent 81bafbf commit a63bf07

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/host_tools/network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def _init_connection(self):
102102
We'll keep trying to execute a remote command that can't fail
103103
(`/bin/true`), until we get a successful (0) exit code.
104104
"""
105-
self.check_output("true", timeout=10, debug=True)
105+
self.check_output("true", timeout=100, debug=True)
106106

107107
def run(self, cmd_string, timeout=None, *, check=False, debug=False):
108108
"""

0 commit comments

Comments
 (0)