tests: changed limit for reusable connections #2301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good catch! Can you please add detail to the commit msg and the PR description around what the newly added behavior is? Without diving deep into the code, I for one can't tell how the changes in this PR should affect behavior. |
gbionescu
reviewed
Nov 24, 2020
luminitavoicu
force-pushed
the
connections_no
branch
2 times, most recently
from
05247be to
b302812
Compare
luminitavoicu
force-pushed
the
connections_no
branch
from
b302812 to
f80f28b
Compare
serban300
previously approved these changes
Nov 25, 2020
The micro-http server holds a HashMap of all open connections and has a limit for the number of active connections at the same time. The `requests_unixsocket` python package, used by the testing framework for issuing API requests, opens a new connection for every API call and keeps it alive even after receiving the response from the server. These sockets are kept inside the connections HashMap and might very easily end up in exceeding the micro-http's limit, triggering a '503' response from the server. To prevent this from happening, the `pool_connections` argument was set to 10, consistent with the maximum number of open connections allowed. Attempts to issue a new API request, after this limit has been reached, implies closing and removing the least recently used open fd and then adding a newly opened connection to the pool. Signed-off-by: Luminita Voicu <lumivo@amazon.com>
luminitavoicu
force-pushed
the
connections_no
branch
from
f80f28b to
aa3e375
Compare
9 tasks
serban300
approved these changes
Nov 25, 2020
acatangiu
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luminita Voicu lumivo@amazon.com
Reason for This PR
The micro-http server holds a HashMap of all opened connections and has a limit for the number of active connections at the same time. The
requests_unixsocketpython package, used by the testing framework for issuing API requests, opens a new connection for every API call and keeps it alive even after receiving the response from the server. These sockets are kept inside the connections HashMap and might very easily end up in exceeding the micro-http's limit, triggering a503response from the server.Description of Changes
To prevent this from happening, the
pool_connectionsargument was set to 10, consistent with the maximum number of open connections allowed:MAX_CONNECTIONS. Attempts to issue a new API request, after this limit has been reached, implies closing and removing the least recently used open fd and then adding a newly opened connection to the pool.rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.