Skip to content

Conversation

@zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Jun 21, 2023

Changes / Reason

Sets FDP_EXCPTN_ONLY bit (CPUID.7h.0:EBX[6]) and ZERO_FCS_FDS bit (CPUID.7h.0:EBX[13]) in Intel's CPUID normalization as recommended in kernel doc. For more details, please refer to
https://lore.kernel.org/all/20220322110712.222449-3-pbonzini@redhat.com/

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@zulinx86 zulinx86 self-assigned this Jun 21, 2023
@zulinx86 zulinx86 added the Type: Fix Indicates a fix to existing code label Jun 21, 2023
@zulinx86 zulinx86 force-pushed the cpuid_normalization branch 3 times, most recently from 1551c2e to 30102c8 Compare June 21, 2023 13:52
Sets FDP_EXCPTN_ONLY bit (CPUID.7h.0:EBX[6]) and ZERO_FCS_FDS bit
(CPUID.7h.0:EBX[13]) in Intel's CPUID normalization as recommended in
kernel doc. For more details, please refer to
https://lore.kernel.org/all/20220322110712.222449-3-pbonzini@redhat.com/

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 force-pushed the cpuid_normalization branch from 30102c8 to 1d9677e Compare June 21, 2023 15:21
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 21, 2023
@zulinx86 zulinx86 merged commit 71010a6 into firecracker-microvm:main Jun 21, 2023
@zulinx86 zulinx86 deleted the cpuid_normalization branch June 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants