Update amd x86_64 cpu features #5314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
==========================================
+ Coverage 82.96% 83.02% +0.05%
==========================================
Files 250 250
Lines 26828 26828
==========================================
+ Hits 22259 22273 +14
+ Misses 4569 4555 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
added
Status: Awaiting review
roypat
approved these changes
Jul 18, 2025
zulinx86
reviewed
Jul 18, 2025
Manciukic
approved these changes
Jul 18, 2025
Nested virtualization is now disabled and some cpu features/MSRs now should be marked as host only. These cpu features/MSRs are described the AMD reference manual at "SVM Revision and Feature Identification" section. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Now this MSR is host only and not available in the guest. Check AMD reference manual at "SVM Revision and Feature Identification" section for more information. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
|
@zulinx86 added a pointer to the section of the reference manual |
thx! double-checked them in https://github.com/torvalds/linux/blob/6832a9317eee280117cd695fa885b2b7a7a38daf/arch/x86/include/asm/cpufeatures.h#L364-L383. |
zulinx86
approved these changes
Jul 18, 2025
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With disabling of nested virtualization on the CI instances, some cpu features/MSR are now host only.
Useful links: https://github.com/torvalds/linux/blob/6832a9317eee280117cd695fa885b2b7a7a38daf/arch/x86/include/asm/cpufeatures.h#L364-L383.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.