Fix MSIx interrupts #5353
Merged
Fix MSIx interrupts #5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
Manciukic
previously approved these changes
Aug 11, 2025
bchalios
force-pushed
the
fix_msix_interrupts
branch
from
d9fc204 to
8c23ce6
Compare
bchalios
dismissed
roypat’s stale review
The merge-base changed after approval.
bchalios
force-pushed
the
fix_msix_interrupts
branch
from
8c23ce6 to
1268508
Compare
roypat
previously approved these changes
Aug 12, 2025
We should check that the MSI-X vector that a guest assigns to a VirtIO queue or configuration is a valid one. If it is a value bigger than the available vectors allocated for the device, it should not update the vector field and mark the corresponding vector to the NO_VECTOR value. Also, add checks in the MSI implementation for VirtioInterrupt trait, for making sure that we don't try to interact with out-of-range interrupt vectors. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
fix_msix_interrupts
branch
from
1268508 to
af5c750
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pcie #5353 +/- ##
================================================
- Coverage 80.64% 80.59% -0.05%
================================================
Files 265 265
Lines 30674 30690 +16
================================================
- Hits 24737 24736 -1
- Misses 5937 5954 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
approved these changes
Aug 12, 2025
roypat
approved these changes
Aug 12, 2025
bchalios
merged commit 1e675c2
into
firecracker-microvm:feature/pcie
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Validate the interrupt vectors that guest selects for VirtIO queues and configuration interrupts. Also, make sure that the MSI implementation of
VirtioInterruptchecks that the interrupt index corresponds to a valid interrupt vector.Reason
If the guest sets an invalid vector for a VirtIO queue and/or configuration, we might end up doing an out-of-bounds access to the table that holds the MSI vectors and cause a panic at runtime.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.