Skip to content

Conversation

Manciukic
Copy link
Contributor

@Manciukic Manciukic commented Aug 14, 2025

Changes

This change adds the required error handling. In case a process terminates, the get_cpu_times will return an empty dict and the get_cpu_utilization will also return an empty dict. In case a thread dies, the cpu usage of that thread will be omitted from get_cpu_times and get_cpu_utilization (due to the set intersection). In all cases, track_cpu_utilization will only add to the list of values the threads that are returned, if any.

Reason

The logic I've added to monitor the CPU wasn't handling the error when the process or thread died.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

The logic I've added to monitor the CPU wasn't handling the error when
the process or thread died.
This change adds the required error handling. In case a process
terminates, the get_cpu_times will return an empty dict and the
get_cpu_utilization will also return an empty dict. In case a thread
dies, the cpu usage of that thread will be omitted from get_cpu_times
and get_cpu_utilization (due to the set intersection). In all cases,
track_cpu_utilization will only add to the list of values the threads
that are returned, if any.

Signed-off-by: Riccardo Mancini <mancio@amazon.com>
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (283e574) to head (0c0279a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5382      +/-   ##
==========================================
+ Coverage   82.31%   82.35%   +0.04%     
==========================================
  Files         265      265              
  Lines       30645    30645              
==========================================
+ Hits        25224    25238      +14     
+ Misses       5421     5407      -14     
Flag Coverage Δ
5.10-c5n.metal 82.32% <ø> (ø)
5.10-m5n.metal 82.32% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 81.61% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 78.92% <ø> (ø)
5.10-m6i.metal 82.32% <ø> (ø)
5.10-m7a.metal-48xl 81.60% <ø> (?)
5.10-m7g.metal 78.92% <ø> (ø)
5.10-m7i.metal-24xl 82.29% <ø> (?)
5.10-m7i.metal-48xl 82.29% <ø> (?)
5.10-m8g.metal-24xl 78.92% <ø> (?)
5.10-m8g.metal-48xl 78.92% <ø> (?)
6.1-c5n.metal 82.36% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 82.37% <ø> (+0.01%) ⬆️
6.1-m6a.metal 81.65% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 78.91% <ø> (-0.01%) ⬇️
6.1-m6i.metal 82.36% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 81.64% <ø> (?)
6.1-m7g.metal 78.92% <ø> (ø)
6.1-m7i.metal-24xl 82.38% <ø> (?)
6.1-m7i.metal-48xl 82.38% <ø> (?)
6.1-m8g.metal-24xl 78.92% <ø> (?)
6.1-m8g.metal-48xl 78.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manciukic Manciukic marked this pull request as ready for review August 14, 2025 12:35
@Manciukic Manciukic enabled auto-merge (rebase) August 14, 2025 12:50
@Manciukic Manciukic merged commit d974044 into firecracker-microvm:main Aug 14, 2025
7 checks passed
@Manciukic Manciukic deleted the fix-cpu-monitor branch August 14, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants