Add integ tests for GDB and a flag for the sandbox tool #5527
+148
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5527 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 270 270
Lines 27784 27784
=======================================
Hits 23028 23028
Misses 4756 4756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The integ test opens gdb on a subprocess which connects to Firecracker, sets a breakpoint and continues until boot is complete. If the VM boots correctly and the breakpoint gets hit, then the test will succeed. This test currently only works on x86 as GDB requires a vmlinux image (we use a uImage on ARM). Signed-off-by: Riccardo Mancini <mancio@amazon.com>
This adds a sandbox option to setup GDB automatically and open it in a new tmux window. This makes it easier to use GDB with firecracker using common tooling. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
The cmd_fmt wouldn't format like the CI test would like it. This commit fixes the issue. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this depends on #5524 for the
validate_api=Falseflags (unless I remove them from here to make this CR merge first).Changes
--gdbflag in the sandbox toolReason
GDB was broken, I fixed it, and I don't want it to break again without anybody noticing.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.