test: Update MSR baseline #5530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got to specify IA32_MTRRdefType MSR to allow guest OS to set page attributes for memory regions, which cause guest OS to chage IA32_PAT MSR value. Note that we don't need to add IA32_PAT MSR to the exception list because guest OS always set the same value to it and it doesn't change every boot. Rather, by keeping monitoring it, we may be able to catch changes caused by guest OS updates. [1]: firecracker-microvm#5526 Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
added
the
Status: Awaiting review
Contributor
Author
|
will make the test run in the optional test suite on this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5530 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 270 270
Lines 27784 27784
=======================================
Hits 23028 23028
Misses 4756 4756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is only one test marked as no_block_pr right now and it is test_guest_cpu_config_change. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Adds no_block_pr marker to test_cpu_rdmsr to run in the PR optional test. Also change the marker specification for the CPU template pipeline to keep it run in the pipeline. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
JackThomson2
approved these changes
Nov 24, 2025
Manciukic
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got to specify IA32_MTRRdefType MSR to allow guest OS to set page attributes for memory regions, which cause guest OS to chage IA32_PAT MSR value. Note that we don't need to add IA32_PAT MSR to the exception list because guest OS always set the same value to it and it doesn't change every boot. Rather, by keeping monitoring it, we may be able to catch changes caused by guest OS updates.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.