Skip to content

runtime: txn_ctx refactor pt 1 #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2025
Merged

runtime: txn_ctx refactor pt 1 #7135

merged 1 commit into from
Nov 13, 2025

Conversation

@ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented Nov 7, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052697 s 0.052938 s 0.457% ✅
backtest mainnet-368528500-perf snapshot load 1.704 s 1.692 s -0.704% ✅
backtest mainnet-368528500-perf total elapsed 52.696948 s 52.938063 s 0.458% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.062371 s 0.050433 s -19.140% ✅
backtest mainnet-368528500-perf snapshot load 1.779 s 1.394 s -21.641% ✅
backtest mainnet-368528500-perf total elapsed 62.371176 s 50.433057 s -19.140% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052831 s 0.052618 s -0.403% ✅
backtest mainnet-368528500-perf snapshot load 1.731 s 1.664 s -3.871% ✅
backtest mainnet-368528500-perf total elapsed 52.830611 s 52.617903 s -0.403% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076119 s 0.075859 s -0.342% ✅
backtest mainnet-368528500-perf snapshot load 2.638 s 2.617 s -0.796% ✅
backtest mainnet-368528500-perf total elapsed 76.119454 s 75.858894 s -0.342% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.072885 s 0.072863 s -0.030% ✅
backtest mainnet-368528500-perf snapshot load 2.653 s 2.631 s -0.829% ✅
backtest mainnet-368528500-perf total elapsed 72.885372 s 72.86256 s -0.031% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.063788 s 0.063908 s 0.188% ✅
backtest mainnet-368528500-perf snapshot load 2.163 s 2.13 s -1.526% ✅
backtest mainnet-368528500-perf total elapsed 63.788094 s 63.908429 s 0.189% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

@ibhatt-jumptrading ibhatt-jumptrading changed the title runtime: error code handling cleanup [wip, don't review] runtime: error code handling cleanup Nov 9, 2025
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076055 s 0.076133 s 0.103% ✅
backtest mainnet-368528500-perf snapshot load 2.653 s 2.63 s -0.867% ✅
backtest mainnet-368528500-perf total elapsed 76.055115 s 76.133494 s 0.103% ✅
firedancer mem usage with mainnet.toml 991.14 GiB 991.14 GiB 0.000% ✅

mmcgee-jump
mmcgee-jump reviewed Nov 10, 2025
View reviewed changes
src/flamenco/runtime/fd_executor.c Outdated
int found = fd_txncache_query( txn_ctx->status_cache, txn_ctx->bank->txncache_fork_id, blockhash->uc, txn_ctx->blake_txn_msg_hash.uc );
if( FD_UNLIKELY( found ) ) return FD_RUNTIME_TXN_ERR_ALREADY_PROCESSED;
if( FD_UNLIKELY( found ) ) {
FD_LOG_WARNING(( "transaction already processed: %d", found ));
Copy link
Contributor

@mmcgee-jump mmcgee-jump Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray?

Copy link
Contributor Author

@ibhatt-jumptrading ibhatt-jumptrading Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes oops

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.061402 s 0.051654 s -15.876% ✅
backtest mainnet-368528500-perf snapshot load 1.796 s 1.445 s -19.543% ✅
backtest mainnet-368528500-perf total elapsed 61.401694 s 51.654334 s -15.875% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.063914 s 0.065315 s 2.192% ✅
backtest mainnet-368528500-perf snapshot load 2.154 s 2.135 s -0.882% ✅
backtest mainnet-368528500-perf total elapsed 63.913567 s 65.315285 s 2.193% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076478 s 0.076209 s -0.352% ✅
backtest mainnet-368528500-perf snapshot load 2.666 s 2.628 s -1.425% ✅
backtest mainnet-368528500-perf total elapsed 76.477569 s 76.208759 s -0.351% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.053023 s 0.053059 s 0.068% ✅
backtest mainnet-368528500-perf snapshot load 1.731 s 1.657 s -4.275% ✅
backtest mainnet-368528500-perf total elapsed 53.023302 s 53.058617 s 0.067% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073037 s 0.0733 s 0.360% ✅
backtest mainnet-368528500-perf snapshot load 2.679 s 2.629 s -1.866% ✅
backtest mainnet-368528500-perf total elapsed 73.037369 s 73.29963 s 0.359% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073561 s 0.073442 s -0.162% ✅
backtest mainnet-368528500-perf snapshot load 2.658 s 2.633 s -0.941% ✅
backtest mainnet-368528500-perf total elapsed 73.561022 s 73.442355 s -0.161% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052775 s 0.052876 s 0.191% ✅
backtest mainnet-368528500-perf snapshot load 1.751 s 1.658 s -5.311% ✅
backtest mainnet-368528500-perf total elapsed 52.774666 s 52.875573 s 0.191% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.060997 s 0.051441 s -15.666% ✅
backtest mainnet-368528500-perf snapshot load 1.944 s 1.415 s -27.212% ✅
backtest mainnet-368528500-perf total elapsed 60.997481 s 51.440519 s -15.668% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076333 s 0.076613 s 0.367% ✅
backtest mainnet-368528500-perf snapshot load 2.62 s 2.622 s 0.076% ✅
backtest mainnet-368528500-perf total elapsed 76.333017 s 76.612906 s 0.367% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@ibhatt-jumptrading ibhatt-jumptrading changed the title runtime: error code handling cleanup runtime: txn_ctx refactor [wip] Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052923 s 0.05291 s -0.025% ✅
backtest mainnet-368528500-perf snapshot load 1.741 s 1.675 s -3.791% ✅
backtest mainnet-368528500-perf total elapsed 52.923228 s 52.910083 s -0.025% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073353 s 0.073322 s -0.042% ✅
backtest mainnet-368528500-perf snapshot load 2.708 s 2.626 s -3.028% ✅
backtest mainnet-368528500-perf total elapsed 73.352846 s 73.322305 s -0.042% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076316 s 0.076097 s -0.287% ✅
backtest mainnet-368528500-perf snapshot load 2.667 s 2.619 s -1.800% ✅
backtest mainnet-368528500-perf total elapsed 76.316301 s 76.09679 s -0.288% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076431 s 0.076212 s -0.287% ✅
backtest mainnet-368528500-perf snapshot load 2.664 s 2.662 s -0.075% ✅
backtest mainnet-368528500-perf total elapsed 76.430609 s 76.211742 s -0.286% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.052975 s 0.053241 s 0.502% ✅
backtest mainnet-368528500-perf snapshot load 1.711 s 1.656 s -3.214% ✅
backtest mainnet-368528500-perf total elapsed 52.97506 s 53.241423 s 0.503% ✅
firedancer mem usage with mainnet.toml 992.14 GiB 992.14 GiB 0.000% ✅

mmcgee-jump
mmcgee-jump reviewed Nov 12, 2025
View reviewed changes
@ibhatt-jumptrading ibhatt-jumptrading force-pushed the ibhatt/cleanup branch 2 times, most recently from bb3d6b7 to 49cd9ca Compare November 12, 2025 21:15
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076209 s 0.076306 s 0.127% ✅
backtest mainnet-368528500-perf snapshot load 3.107 s 2.973 s -4.313% ✅
backtest mainnet-368528500-perf total elapsed 76.208574 s 76.306221 s 0.128% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.054691 s 0.054547 s -0.263% ✅
backtest mainnet-368528500-perf snapshot load 2.627 s 1.763 s -32.889% ✅
backtest mainnet-368528500-perf total elapsed 54.69082 s 54.546586 s -0.264% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@ibhatt-jumptrading ibhatt-jumptrading changed the title runtime: txn_ctx refactor [wip] runtime: txn_ctx refactor pt 1 Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.065355 s 0.065958 s 0.923% ✅
backtest mainnet-368528500-perf snapshot load 2.424 s 2.354 s -2.888% ✅
backtest mainnet-368528500-perf total elapsed 65.355047 s 65.958417 s 0.923% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

yufeng-jump
yufeng-jump previously approved these changes Nov 13, 2025
View reviewed changes
src/flamenco/runtime/fd_runtime.c
int res = fd_cost_tracker_calculate_cost_and_add( cost_tracker, txn_ctx );
if( FD_UNLIKELY( res!=FD_COST_TRACKER_SUCCESS ) ) {
txn_ctx->flags = 0U;
FD_LOG_DEBUG(( "fd_runtime_finalize_txn: transaction failed to fit into block %d", res ));
Copy link
Contributor

@yufeng-jump yufeng-jump Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a CRIT in bank that already logs a superset of info. Maybe remove this and add a debug log in exec tile for transactions that overflow cost tracker? Also might as well log the transaction signature in case it's a rare cost tracker bug.

Copy link
Contributor Author

@ibhatt-jumptrading ibhatt-jumptrading Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessarily this transaction that caused cost tracker problems tbf. it could've been any transaction in the block and this transaction is the one that set it over

src/discof/bank/fd_bank_tile.c Outdated

uint actual_execution_cus = (uint)(txn_ctx->compute_budget_details.compute_unit_limit - txn_ctx->compute_budget_details.compute_meter);
uint actual_acct_data_cus = (uint)(txn_ctx->loaded_accounts_data_size_cost);
ctx->metrics.txn_landed[ FD_METRICS_ENUM_TRANSACTION_LANDED_V_LANDED_SUCESS_IDX ]++;
Copy link
Contributor

@yufeng-jump yufeng-jump Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check txn_ctx->err.exec_err before incrementing this? Otherwise this will count LANDED_FAILED too.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.054355 s 0.054515 s 0.294% ✅
backtest mainnet-368528500-perf snapshot load 2.561 s 1.797 s -29.832% ✅
backtest mainnet-368528500-perf total elapsed 54.355168 s 54.514662 s 0.293% ✅
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000% ✅

@ibhatt-jumptrading ibhatt-jumptrading merged commit 14c4245 into main Nov 13, 2025
12 checks passed
@ibhatt-jumptrading ibhatt-jumptrading deleted the ibhatt/cleanup branch November 13, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmcgee-jump mmcgee-jump mmcgee-jump left review comments

@yufeng-jump yufeng-jump yufeng-jump approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ibhatt-jumptrading @mmcgee-jump @yufeng-jump