Skip to content

Dirichlet sub vfs #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2016
Merged

Dirichlet sub vfs #844

merged 3 commits into from
Jul 29, 2016

Conversation

@wence-
Copy link
Contributor

@wence- wence- commented Jul 29, 2016

Fixes a regression Justin reported on the mailing list

Hi all,

Last year (~8 months ago) the following worked:

from firedrake import *
mesh = UnitSquareMesh(10,10)
V = VectorFunctionSpace(mesh, "CG", 1)
P = FunctionSpace(mesh, "CG", 1)
W = V*Q
bc1 = DirichletBC(W.sub(0).sub(0), Expression("cos(pi*x[0])*sin(pi*x[1])"), (1,2))

wence- added 3 commits July 29, 2016 08:46
@wence-
FS: fix format argument in ProxyFunctionSpace
234e788
@wence-
Add tests of subscripted VFS bcs using Expressions
bd42040 
Demonstrates a regression where if an Expression object is passed in we
get an error.
@wence-
Fix regression applying bcs to subscripted VFS
e9c42de 
Only appeared when using Expression objects.
@miklos1
Copy link
Member

miklos1 commented Jul 29, 2016

Looks fine.

@wence- wence- merged commit e9c42de into master Jul 29, 2016
wence- added a commit that referenced this pull request Jul 29, 2016
@wence-
Merge pull request #844 from firedrakeproject/dirichlet-sub-vfs
1f8fa56 
* dirichlet-sub-vfs:
  Fix regression applying bcs to subscripted VFS
  Add tests of subscripted VFS bcs using Expressions
  FS: fix format argument in ProxyFunctionSpace
@wence- wence- deleted the dirichlet-sub-vfs branch July 29, 2016 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wence- @miklos1