Skip to content

feat: snake case the evse state #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022
Merged

feat: snake case the evse state #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
291220f
feat: snake case the evse state
firstof9 Nov 1, 2022
4969c0e
fix tests
firstof9 Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions openevsehttp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,19 @@
_LOGGER = logging.getLogger(__name__)

states = {
0: "unknown",
1: "not connected",
2: "connected",
3: "charging",
4: "vent required",
5: "diode check failed",
6: "gfci fault",
7: "no ground",
8: "stuck relay",
9: "gfci self-test failure",
10: "over temperature",
254: "sleeping",
255: "disabled",
0: "Unknown",
1: "Not Connected",
2: "Connected",
3: "Charging",
4: "Vent Required",
5: "Diode Check Failed",
6: "GFCI Fault",
7: "No Ground",
8: "Stuck Relay",
9: "GFCI Self-Test Failure",
10: "Over Temperature",
254: "Sleeping",
255: "Disabled",
}

ERROR_AUTH_FAILURE = "Authorization failure"
Expand Down
6 changes: 3 additions & 3 deletions tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async def test_get_status_auth(test_charger_auth):
"""Test v4 Status reply."""
await test_charger_auth.update()
status = test_charger_auth.status
assert status == "sleeping"
assert status == "Sleeping"


async def test_get_status_auth_err(test_charger_auth_err):
Expand Down Expand Up @@ -134,7 +134,7 @@ async def test_send_command_server_timeout(test_charger_auth, mock_aioclient, ca

@pytest.mark.parametrize(
"fixture, expected",
[("test_charger", "sleeping"), ("test_charger_v2", "not connected")],
[("test_charger", "Sleeping"), ("test_charger_v2", "Not Connected")],
)
async def test_get_status(fixture, expected, request):
"""Test v4 Status reply."""
Expand Down Expand Up @@ -491,7 +491,7 @@ async def test_get_vehicle(fixture, expected, request):

@pytest.mark.parametrize(
"fixture, expected",
[("test_charger", "sleeping"), ("test_charger_v2", "not connected")],
[("test_charger", "Sleeping"), ("test_charger_v2", "Not Connected")],
)
async def test_get_state(fixture, expected, request):
"""Test v4 Status reply."""
Expand Down