Skip to content

fix: if max_current_soft doesn't exist return the pilot value #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

fix: if max_current_soft doesn't exist return the pilot value #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958d002
fix: if max_current_soft doesn't exist return the pilot value
firstof9 Nov 6, 2022
08a6800
fix test
firstof9 Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openevsehttp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ def max_current_soft(self) -> int | None:
"""Return the firmware version."""
if self._config is not None and "max_current_soft" in self._config:
return self._config["max_current_soft"]
return None
return self._status["pilot"]

@property
def wifi_firmware(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ async def test_vehicle_eta(fixture, expected, request):


@pytest.mark.parametrize(
"fixture, expected", [("test_charger", 48), ("test_charger_v2", None)]
"fixture, expected", [("test_charger", 48), ("test_charger_v2", 25)]
)
async def test_max_current_soft(fixture, expected, request):
"""Test max_current_soft reply."""
Expand Down