feat: add version check to toggle_override function #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firstof9
added a commit
that referenced
this pull request
Jan 12, 2022
* add set_charge_mode function Utilizes the HTTP API to set the charge_mode configuration. * refactor: move all aiohttp handling into separate function * fix: make websocket listener not automatic (#12) * fix tests * handle running loop better * formatting * rename variable * refactor: update websocket error message with correct url * add python 3.10 to tests * Capture additional properties from OpenEVSE status (#15) * Add manual_override and divertmode * Add available_current, charge_rate and divert_active properties * Add smoothed_available_current * Add several additional properties - manual_override - divertmode - available_current - charge_rate - divert_active - smoothed_available_current * formatting * linting * feat: add version check to toggle_override function (#24) * docs: placeholder * feat: add divertmode function * refactor: formatting and linting * feat: add version check to toggle_override * formatting and linting * version bump * tests: update tests * tests: more test updates * tests: add another test * tests: add toggle_override test * formatting * tests: fix test Co-authored-by: Jose Carlos Garcia Sogo <jcsogo@gmail.com>
firstof9
added a commit
that referenced
this pull request
Jan 12, 2022
* docs: placeholder * feat: add divertmode function * refactor: formatting and linting * feat: add version check to toggle_override * formatting and linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a firmware version check for the toggle_overrride function to send RAPI commands for firmware version lower than
4.0.0