Skip to content

fix: adjust power calculation function #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2022
Merged

fix: adjust power calculation function #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b1f29
fix: adjust power calculation function
firstof9 Sep 11, 2022
d503ce0
adjust pylint config
firstof9 Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions openevsehttp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,14 +816,16 @@ def wifi_serial(self) -> str | None:
return None

@property
def charging_power(self) -> float:
def charging_power(self) -> float | None:
"""Return the charge power.

Calculate Watts base on V*I
"""
assert self._status is not None
value = round(self._status["voltage"] * self._status["amp"], 2)
return value
if self._status is not None and any(
key in self._status for key in ["voltage", "amp"]
):
return round(self._status["voltage"] * self._status["amp"], 2)
return None

# There is currently no min/max amps JSON data
# available via HTTP API methods
Expand Down
2 changes: 0 additions & 2 deletions pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ max-attributes=15
# too-few-* - same as too-many-*
# import-outside-toplevel - TODO
disable=
bad-continuation,
duplicate-code,
fixme,
import-outside-toplevel,
Expand All @@ -26,7 +25,6 @@ disable=
too-many-public-methods,
too-many-instance-attributes,
too-many-branches,
no-self-use,
too-many-statements

[REPORTS]
Expand Down