Skip to content

Commit 8b30d60

Browse files
authored
fix(sdk): remove update record not upserted (#149)
This is similar to #148 but for invalid update found in the example input.json.
1 parent 2f0088b commit 8b30d60

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

development-guide/destination-connector-development-guide.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,4 +154,7 @@ The following is a list of test scenarios we recommend you consider:
154154
Yes, definitely. This happens during the [initial sync](https://fivetran.com/docs/getting-started/glossary#initialsync) or a [re-sync](https://fivetran.com/docs/using-fivetran/features#resync) where the source connector first calls the `truncate` operation and then `upserts`. The `truncate` in this case is meant to (soft) delete any rows that may have existed prior to the initial sync starting. This is done to make sure all rows that may have existed prior to the initial sync are marked as deleted (since we cannot be sure the initial sync will necessarily overwrite them all). It should pick out the rows that existed prior to the sync starting, in other words, where `_fivetran_synced` < "timestamp when `truncate` is called in the source connector".
155155

156156
### What happens if a source connector sends a delete event for a record that was never upserted?
157-
Deletes for records that were never upserted are safely ignored — no action should be taken.
157+
Deletes for records that were never upserted are safely ignored — no action should be taken.
158+
159+
### What happens if a source connector sends an update event for a record that was never upserted?
160+
Updates for records that were never upserted are safely ignored — no action should be taken.

tools/destination-connector-tester/input-files/input.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,12 +205,6 @@
205205
"amount_double": 400.555,
206206
"flag": false,
207207
"op_time": "2023-10-30T15:00:00Z"
208-
},
209-
{
210-
"id": 999,
211-
"amount_double": 0,
212-
"flag": false,
213-
"op_time": "2023-10-30T15:00:00Z"
214208
}
215209
]
216210
}

0 commit comments

Comments
 (0)