handle edge cases in block decoder partition point and range iteration #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaidoon1
force-pushed
the
zaidoon/edge-cases-block-decoder
branch
from
10ce7a8 to
b1b682e
Compare
restart_interval > 1 is currently not implemented for index blocks, but if it is, we can not rely on the restart head itself, but also must do the linear scan
|
I think this looks correct. I wanted to get rid of the partition_point/partition_point_2 split, but looking at it, I don't think that is really all that possible or that it would make things any more ergonomic... I will merge this after the index block fuzz tests are restored - in #161. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #165