Skip to content

Error message improvement #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2017
Merged

Error message improvement #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c345edd
Error message example
fjmorant Oct 16, 2017
e687052
Better error message
fjmorant Oct 17, 2017
2792cfb
Fix flowconfig
fjmorant Oct 17, 2017
6fe5335
Fix flow issues
fjmorant Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
flow-typed
flow-typed
examples
2 changes: 2 additions & 0 deletions .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

.*/node_modules/*

.*/examples/*

; Ignore duplicate module providers
; For RN Apps installed via npm, "Libraries" folder is inside
; "node_modules/react-native" but in the source repo it is in the root
Expand Down
3 changes: 2 additions & 1 deletion NodeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ export default class NodeView extends React.PureComponent<Props, State> {
)
}

renderItem = ({item}) => this.renderChildren(item, this.props.level)
renderItem = ({item}: {item: Node}) =>
this.renderChildren(item, this.props.level)

render() {
const rootChildrenName = this.props.getChildrenName(this.state.node)
Expand Down
Loading