Feat/idl func #275
Merged
Feat/idl func #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, adding an optional argument to the I/O function is probably not an issue if it provides a functionality that is useful. Could you implement tests for the new feature (and fix the linting errors)? |
Collaborator
Author
|
Sure, there you go. |
fjosw
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option for the user to supply their own function to extract the number of the configuration from file names (or in the append mode the line that includes the gauge name).
This is particularly useful for the append-mode, as one may have the case that the configuration file has a postfix (for example
.lex).It is a fix to a problem I was made aware of via PM.
While the fix introduces yet another option for the SFCF read-in, this was a way to keep things backwards compatible.