feat(flame_3d)!: Allow for nested Component3D by using world matrix calculations#3867
Merged
wolfenrain merged 3 commits intomainfrom Mar 21, 2026
Merged
Conversation
wolfenrain
force-pushed
the
feat/add-nested-compontent3d-support
branch
from
bbf74e5 to
6bcd625
Compare
wolfenrain
force-pushed
the
feat/add-nested-compontent3d-support
branch
from
6bcd625 to
2544273
Compare
luanpotter
approved these changes
Mar 21, 2026
Member
luanpotter
left a comment
luanpotter
left a comment
There was a problem hiding this comment.
LGTM - I assume this works with animations?
also just to be clear, for any moving component, the matrix will be dirty every single tick right? the cache is just to optmize for non-moving things?
Contributor
Author
Yes sir, every time our matrix gets dirty we re-calc and cache it's own and propagate that to it's children. We can probably optimize this further later on but for now it seems to work fine enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a world matrix to use across the tree for proper nested 3D components.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues