Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
apply_dynamic_mask_1rowblockfunction and its usage in theDynamicMaskstruct to improve memory management by replacing the use of shared memory with explicit buffer parameters. These changes enhance clarity and flexibility in memory handling.Memory management improvements:
csrc/src/mask.h: Updated theapply_dynamic_mask_1rowblockfunction to remove the use ofextern __shared__memory and instead take explicit parameters forrow_vals,sort_keys, andsort_indicesas shared memory buffers. This change makes memory usage more explicit and configurable.csrc/src/mask.h: Modified theDynamicMaskstruct to pass the new buffer parameters (row_vals,sort_keys,sort_indices) to theapply_dynamic_mask_1rowblockfunction, aligning its usage with the updated function signature.