Skip to content

Conversation

@LoserCheems
Copy link
Collaborator

This pull request updates the apply_dynamic_mask_1rowblock function and its usage in the DynamicMask struct to improve memory management by replacing the use of shared memory with explicit buffer parameters. These changes enhance clarity and flexibility in memory handling.

Memory management improvements:

  • csrc/src/mask.h: Updated the apply_dynamic_mask_1rowblock function to remove the use of extern __shared__ memory and instead take explicit parameters for row_vals, sort_keys, and sort_indices as shared memory buffers. This change makes memory usage more explicit and configurable.
  • csrc/src/mask.h: Modified the DynamicMask struct to pass the new buffer parameters (row_vals, sort_keys, sort_indices) to the apply_dynamic_mask_1rowblock function, aligning its usage with the updated function signature.

@LoserCheems LoserCheems merged commit 9672475 into main May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants